New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in anomymous mode #3305
Conversation
Login bug (submit button not working) and refresh bug (JS null exception, and then 403).
(Minz_Request::controllerName() === 'user' && Minz_Request::actionName() === 'create' && | ||
!FreshRSS_Auth::hasAccess('admin')) | ||
(Minz_Request::controllerName() === 'user' && Minz_Request::actionName() === 'create' && !FreshRSS_Auth::hasAccess('admin')) || | ||
(Minz_Request::controllerName() === 'feed' && Minz_Request::actionName() === 'actualize' && FreshRSS_Context::$system_conf->allow_anonymous_refresh) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception to permit anonymous refresh (if allowed in the config)
@@ -51,7 +51,7 @@ function init_crypto_form() { | |||
|
|||
forgetOpenCategories(); | |||
|
|||
const submit_button = document.querySelector('button[type="submit"]'); | |||
const submit_button = document.getElementById('loginButton'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In anonymous mode, we have two submit buttons!
@@ -1170,6 +1170,11 @@ function updateFeed(feeds, feeds_count) { | |||
function init_actualize() { | |||
let auto = false; | |||
|
|||
const actualize = document.getElementById('actualize'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In anonymous mode, there is not always an actualize button...
Let's merge, as it is a mildly urgent fix |
Login bug (submit button not working) and refresh bug (JS null exception, and then 403).