Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in anomymous mode #3305

Merged
merged 3 commits into from Dec 30, 2020
Merged

Fix bugs in anomymous mode #3305

merged 3 commits into from Dec 30, 2020

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Dec 29, 2020

Login bug (submit button not working) and refresh bug (JS null exception, and then 403).

Login bug (submit button not working) and refresh bug (JS null
exception, and then 403).
(Minz_Request::controllerName() === 'user' && Minz_Request::actionName() === 'create' &&
!FreshRSS_Auth::hasAccess('admin'))
(Minz_Request::controllerName() === 'user' && Minz_Request::actionName() === 'create' && !FreshRSS_Auth::hasAccess('admin')) ||
(Minz_Request::controllerName() === 'feed' && Minz_Request::actionName() === 'actualize' && FreshRSS_Context::$system_conf->allow_anonymous_refresh) ||
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception to permit anonymous refresh (if allowed in the config)

@@ -51,7 +51,7 @@ function init_crypto_form() {

forgetOpenCategories();

const submit_button = document.querySelector('button[type="submit"]');
const submit_button = document.getElementById('loginButton');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In anonymous mode, we have two submit buttons!

@@ -1170,6 +1170,11 @@ function updateFeed(feeds, feeds_count) {
function init_actualize() {
let auto = false;

const actualize = document.getElementById('actualize');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In anonymous mode, there is not always an actualize button...

@Alkarex Alkarex merged commit 5ca961b into FreshRSS:master Dec 30, 2020
@Alkarex Alkarex deleted the fix_anonymous branch December 30, 2020 23:13
@Alkarex
Copy link
Member Author

Alkarex commented Dec 30, 2020

Let's merge, as it is a mildly urgent fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant