Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor requirement check in install #3368

Merged
merged 1 commit into from Jan 23, 2021

Conversation

aledeg
Copy link
Member

@aledeg aledeg commented Jan 14, 2021

Changes proposed in this pull request:

  • Add requirement check template during install

How to test the feature manually:

  1. Make a new FreshRSS install

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

I've extracted the template in the check requirement to
ensure that future modifications will be easier.

@Alkarex Alkarex added this to the 1.18.0 milestone Jan 14, 2021
@aledeg aledeg force-pushed the enhance/check-install branch 2 times, most recently from 0058a41 to 6963916 Compare January 14, 2021 23:18
I've extracted the template in the check requirement to
ensure that future modifications will be easier.
@Alkarex Alkarex merged commit 297d188 into FreshRSS:master Jan 23, 2021
@aledeg
Copy link
Member Author

aledeg commented Jan 23, 2021

I've messed up the translation in that one. I fixed it in #3373

@aledeg aledeg deleted the enhance/check-install branch January 23, 2021 22:03
<?php
printStep1Template('php', $res['php'], [PHP_VERSION, FRESHRSS_MIN_PHP_VERSION]);
printStep1Template('pdo', $res['pdo']);
printStep1Template('curl', $res['curl'], [$version['version']]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledeg Ups, I did not spot it, but the variable $version is undefined

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in #3427

aledeg added a commit to aledeg/FreshRSS that referenced this pull request Feb 6, 2021
When refactoring the install in FreshRSS#3368, a variable was unwillingly removed.
It's back in the code now.
@aledeg aledeg mentioned this pull request Feb 6, 2021
4 tasks
aledeg added a commit to aledeg/FreshRSS that referenced this pull request Feb 6, 2021
When refactoring the install in FreshRSS#3368, a variable was unwillingly removed.
It's back in the code now.
Alkarex pushed a commit that referenced this pull request Feb 6, 2021
When refactoring the install in #3368, a variable was unwillingly removed.
It's back in the code now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants