New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor requirement check in install #3368
Conversation
0058a41
to
6963916
Compare
I've extracted the template in the check requirement to ensure that future modifications will be easier.
6963916
to
6ffa622
Compare
I've messed up the translation in that one. I fixed it in #3373 |
<?php | ||
printStep1Template('php', $res['php'], [PHP_VERSION, FRESHRSS_MIN_PHP_VERSION]); | ||
printStep1Template('pdo', $res['pdo']); | ||
printStep1Template('curl', $res['curl'], [$version['version']]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledeg Ups, I did not spot it, but the variable $version
is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in #3427
When refactoring the install in FreshRSS#3368, a variable was unwillingly removed. It's back in the code now.
When refactoring the install in FreshRSS#3368, a variable was unwillingly removed. It's back in the code now.
When refactoring the install in #3368, a variable was unwillingly removed. It's back in the code now.
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.
I've extracted the template in the check requirement to
ensure that future modifications will be easier.