Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show all" option on labels #3472

Merged
merged 1 commit into from Feb 26, 2021

Conversation

aledeg
Copy link
Member

@aledeg aledeg commented Feb 20, 2021

Closes #3263

Changes proposed in this pull request:

  • "Show all" option on labels

How to test the feature manually:

  1. Modify the configuration and check the label content

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

It uses the favorite option to keep a similar experience through out
the application and also to limit the number of options.

@aledeg aledeg added the UI 🎨 User Interfaces label Feb 20, 2021
@aledeg aledeg added this to the 1.19.0 milestone Feb 20, 2021
@Alkarex Alkarex modified the milestones: 1.19.0, 1.18.0 Feb 20, 2021
It uses the favorite option to keep a similar experience through out
the application and also to limit the number of options.

See FreshRSS#3263
@aledeg aledeg force-pushed the enhance/reading-configuration branch from 23fc430 to 1ca09d6 Compare February 26, 2021 21:27
@Alkarex Alkarex merged commit 449fee7 into FreshRSS:master Feb 26, 2021
@Alkarex
Copy link
Member

Alkarex commented Feb 26, 2021

For another PR, maybe when the option "Show all articles in favourites by default (Applies also on labels)" is enabled, we should also show all the labels, to avoid the empty drop-down menu (example with two labels, but without any unread articles):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] "Show all" default option for labels
2 participants