Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Remove <li> as separator #4597

Merged
merged 8 commits into from Oct 3, 2022
Merged

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Sep 10, 2022

In the dropdown menus there are seperators as <li> without any content.

So I cleaned the HTML and removed the empty <li>

Changes proposed in this pull request:

  • templates (phtml)
  • (S)CSS

How to test the feature manually:

  1. open the dropdown menus
  2. see the separator lines

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Sep 10, 2022
@math-GH math-GH added this to the 1.21.0 milestone Sep 10, 2022
@Alkarex
Copy link
Member

Alkarex commented Oct 3, 2022

Arg, and conflict here as well... Sorry for the delay. Looks otherwise fine

@Alkarex Alkarex merged commit 645224a into FreshRSS:edge Oct 3, 2022
@math-GH math-GH deleted the remove-separator branch October 3, 2022 19:51
@Alkarex Alkarex modified the milestones: 1.21.0, 1.20.1 Oct 9, 2022
@math-GH math-GH mentioned this pull request Oct 27, 2022
2 tasks
math-GH added a commit to math-GH/FreshRSS that referenced this pull request Nov 15, 2022
* templates

* themes

* fix

* fix

* fixes

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants