Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure base path is a string before calling setServerParameter #2

wants to merge 1 commit into
base: master


Copy link

emodric commented Mar 25, 2020

If you have a config like this:

            base_url: "http://admin:admin@"

path is null when parsing the base URL with parse_url, which fails because of the typehint in AbstractBrowser::setServerParameter.

Using http://admin:admin@ (with / at the end) also helps, but it might be okay to allow the URL without / as it is also perfecly valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.