Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mink session access #80

Closed
lchrusciel opened this issue Apr 4, 2019 · 5 comments

Comments

@lchrusciel
Copy link
Member

commented Apr 4, 2019

Upgrade to newest version may end up with the following bug:

[InvalidArgumentException]            
  Session "symfony" is not registered. 

Sticking to version 2.0.4 solves the problem.

Ref. https://travis-ci.org/Brille24/SyliusCustomOptionsPlugin/jobs/511415049

@Zales0123

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Any update about this bug? It also occurred on one of my PR's Sylius/RefundPlugin#131

cc @pamil

@pamil

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

No idea, we could check which code change caused those errors though and start from there.

@Zales0123

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

This one. Do you remember why it was changed @pamil?

Zales0123 added a commit to Sylius/RefundPlugin that referenced this issue May 6, 2019
…k1994)

This PR was merged into the 1.0-dev branch.

Discussion
----------

This should be an applicable fix until the newest versions of FriendsOfBehat/SymfonyExtension#80 are fixed.

Commits
-------

1457e31 Symfony-extension version temporarily locked
@pamil

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@lchrusciel @Zales0123 the bug is related to Sylius' Kernel cleanupContainer method which happens to strip Mink instance.

@pamil

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Evidence: Sylius/RefundPlugin#138 is passing :)

@pamil pamil closed this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.