Fix default checkbox input #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (!$this->_align) { | ||
| $this->templates([ | ||
| 'checkboxContainer' => '<div class="checkbox">{{content}}</div>', |
There was a problem hiding this comment.
All this template juggling is getting ugly and will be difficult to maintain in future. We should have two sets of templates and just select the one required depending on whether user wants horizontal form or not.
There was a problem hiding this comment.
100% - am already thinking of a way to refactor this in a cleaner way.
@schalla pointed out that the tests for the default checkbox input were asserting a wrong markup according to [GetBootstrap]. Since I am not sure about all the other ways checkboxes can be displayed, I left the rest (inline ones and ones used in horinzontal forms untouched). Will revisit if they are reported broken.
jadb
force-pushed
the
fix-default-checkbox-input
branch
from
55153da
to
3c97f05
Compare
|
Merging all recent PRs and then tagging a new patch release for 0.2 before I start work on a 0.3 (dev) to try using widgets for better organizing everything (and hopefully add a couple new features along the way). Might break the API but we're not on 1.0 yet - so any comments welcomed once I create the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schalla pointed out that the tests for the default checkbox
input were asserting a wrong markup according to GetBootstrap.
Since I am not sure about all the other ways checkboxes can
be displayed, I left the rest (inline ones and ones used in
horinzontal forms untouched). Will revisit if they are reported
broken.