Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations #100

Merged
merged 3 commits into from Mar 7, 2020
Merged

Fix migrations #100

merged 3 commits into from Mar 7, 2020

Conversation

@clarkwinkelmann
Copy link
Contributor

clarkwinkelmann commented Mar 7, 2020

First commit fixes an issue on rollback

Second commit fixes an issue when enabling the extension with notices visible.

@imorland was that undefined variable a copy-paste error or is there something else I should be aware of before merging.

POST http://beta12.flarum.localhost/api/extensions/fof-byobu

<br />
<b>Notice</b>:  Undefined variable: permissionKey in <b>/home/clark/Projects/flarum-beta12/vendor/fof/byobu/migrations/2020_02_19_110103_remove_retired_settings_key.php</b> on line <b>15</b><br />
<br />
<b>Notice</b>:  Undefined variable: permissionKey in <b>/home/clark/Projects/flarum-beta12/vendor/fof/byobu/migrations/2020_02_19_110103_remove_retired_settings_key.php</b> on line <b>23</b><br />
<br />
<b>Fatal error</b>:  Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Output has been emitted previously; cannot emit response in /home/clark/Projects/flarum-beta12/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:24
@datitisev datitisev requested a review from imorland Mar 7, 2020
@clarkwinkelmann clarkwinkelmann merged commit 3ece362 into master Mar 7, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.