Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting Guzzle's "base_uri" option #349

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
2 participants
@dunglas
Copy link
Contributor

commented Jun 21, 2018

Allow to set a base URI. Fix #328.

@dunglas dunglas force-pushed the dunglas:fix-base_uri branch from eb284e2 to 71dc217 Jun 21, 2018

@dunglas

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

Any chance to get this PR merged and a new tag added @fabpot? It will allow to improve the compatlbiity of Panthère with existing Symfony test suites: symfony/panther#36

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

Thank you @dunglas.

@fabpot fabpot merged commit 71dc217 into FriendsOfPHP:master Jun 29, 2018

1 of 2 checks passed

fabbot.io Not Found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jun 29, 2018

feature #349 Support setting Guzzle's "base_uri" option (dunglas)
This PR was merged into the 3.2-dev branch.

Discussion
----------

Support setting Guzzle's "base_uri" option

Allow to set a base URI. Fix #328.

Commits
-------

71dc217 Support setting Guzzle's "base_uri" option
@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 29, 2018

Done

@dunglas dunglas deleted the dunglas:fix-base_uri branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.