Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new AbstractBrowser class from BrowserKit #382

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@dunglas
Copy link
Contributor

commented Jun 28, 2019

Required to prevent deprecations.

@dunglas

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

fabpot failure are false positives

@@ -13,7 +13,7 @@
],
"require": {
"php": ">=5.5.0",

This comment has been minimized.

Copy link
@dunglas

dunglas Jun 28, 2019

Author Contributor

Actually, we could also bump the PHP version, and other Symfony dependencies.

This comment has been minimized.

Copy link
@fabpot

fabpot Jun 28, 2019

Member

Please, let's do that. No need to still maintain such an old PHP version.

This comment has been minimized.

Copy link
@adrienlucas

adrienlucas Aug 13, 2019

Contributor

Assuming this would be done in a separate MR, I propose #387
Feel free to cherry-pick or whatever :)

@adrienlucas adrienlucas referenced this pull request Aug 13, 2019
fabpot added a commit that referenced this pull request Sep 8, 2019
feature #387 Remove PHP5 support (adrienlucas)
This PR was merged into the 3.2-dev branch.

Discussion
----------

Remove PHP5 support

As requested there : #382 (comment)

But i'm not sure that we actually want to drop the support for Symfony 2.8... Should we wait for EOL ? Or is there another way ?

Commits
-------

173cac1 Remove PHP5 support
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

Thank you @dunglas.

fabpot added a commit that referenced this pull request Sep 8, 2019
feature #382 Use the new AbstractBrowser class from BrowserKit (dunglas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

Use the new AbstractBrowser class from BrowserKit

Required to prevent deprecations.

Commits
-------

203a4c9 Use the new AbstractBrowser class from BrowserKit

@fabpot fabpot merged commit 203a4c9 into FriendsOfPHP:master Sep 8, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
fabbot.io Some changes should be done to comply with our standards.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.