Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allowed set files for creating HTTP request on client-side #77

Merged
merged 2 commits into from Oct 10, 2012

Conversation

Projects
None yet
4 participants
Contributor

hason commented Sep 6, 2012

@jhedstrom Fixes also #76. Can you test please?

This does indeed fix #76. Thanks!

Contributor

hason commented Sep 10, 2012

@fabpot This PR works with/without symfony/symfony#5407 (no BC).

Contributor

hason commented Oct 10, 2012

@fabpot Please, can you merge this PR?

@fabpot fabpot added a commit that referenced this pull request Oct 10, 2012

@fabpot fabpot merged branch hason/file_client (PR #77)
This PR was merged into the master branch.

Commits
-------

3ae1a8c Fixed regression for a cause if upload failed
c05e1f0 Allowed set files for creating HTTP request on client-side

Discussion
----------

Allowed set files for creating HTTP request on client-side

For description see symfony/symfony#4674 (comment)

Related PRs:

Behat/MinkBrowserKitDriver#1
https://github.com/Behat/MinkGoutteDriver/pull/7
symfony/symfony#5407

---------------------------------------------------------------------------

by hason at 2012-09-06T10:55:52Z

@jhedstrom Fixes also #76. Can you test please?

---------------------------------------------------------------------------

by jhedstrom at 2012-09-06T18:15:27Z

This does indeed fix #76. Thanks!

---------------------------------------------------------------------------

by hason at 2012-09-10T07:49:52Z

@fabpot This PR works with/without symfony/symfony#5407 (no BC).

---------------------------------------------------------------------------

by hason at 2012-10-10T09:26:00Z

@fabpot Please, can you merge this PR?
4c192d5

@fabpot fabpot merged commit 3ae1a8c into FriendsOfPHP:master Oct 10, 2012

Contributor

arithmetric commented Oct 16, 2012

There's a fix for a logic error for this functionality in #81.

@craigmarvelley craigmarvelley pushed a commit to craigmarvelley/symfony that referenced this pull request Nov 26, 2013

@fabpot fabpot merged branch hason/crawler (PR #5407)
This PR was merged into the master branch.

Commits
-------

c902966 [DomCrawler] Added ability to set file as raw path to file field

Discussion
----------

[2.2][DomCrawler] Added ability to set file as raw path to file field

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT

For description see #4674 (symfony#4674 (comment))

Related PRs:

Behat/MinkBrowserKitDriver#1
https://github.com/Behat/MinkGoutteDriver/pull/7
FriendsOfPHP/Goutte#77

---------------------------------------------------------------------------

by stof at 2012-10-13T21:53:27Z

@fabpot anything missing here ?
0fc0fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment