Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnit] Add migration for 7.5 assertEqualsWithDelta #4145

Open
Slamdunk opened this Issue Dec 10, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Slamdunk
Copy link
Contributor

Slamdunk commented Dec 10, 2018

References: https://github.com/sebastianbergmann/phpunit/blob/7.5.0/ChangeLog-7.5.md

Implemented sebastianbergmann/phpunit#3340: Added assertEqualsCanonicalizing(), assertEqualsIgnoringCase(), assertEqualsWithDelta(), assertNotEqualsCanonicalizing(), assertNotEqualsIgnoringCase(), and assertNotEqualsWithDelta() as alternatives to using assertEquals() and assertNotEquals() with the $delta, $canonicalize, or $ignoreCase parameters

The optional parameters $delta, $maxDepth, $canonicalize, and $ignoreCase of assertEquals() and assertNotEquals() are now deprecated. There is no behavioral change in this version of PHPUnit. Using these parameters will trigger a deprecation warning in PHPUnit 8 and in PHPUnit 9 these parameters will be removed.

@TomasVotruba

This comment has been minimized.

Copy link

TomasVotruba commented Dec 10, 2018

AST implementation in Rector for inspiration: rectorphp/rector@334c989#diff-de1172102c1d09f6d2910b0571e5f546

Test cases included. I hope I got them right 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.