New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitattributes to ignore next file #3151

Closed
wants to merge 2 commits into
base: 2.2
from

Conversation

Projects
None yet
2 participants
@keradus
Member

keradus commented Oct 11, 2017

No description provided.

keradus added some commits Oct 11, 2017

@SpacePossum SpacePossum added the cleanup label Oct 11, 2017

@SpacePossum SpacePossum added this to the 2.2.9 milestone Oct 11, 2017

@SpacePossum SpacePossum added the RTM label Oct 11, 2017

@keradus

This comment has been minimized.

Show comment
Hide comment
@keradus

keradus Oct 11, 2017

Member

Any clue why it was green on PR introducing this file?
#3133

Member

keradus commented Oct 11, 2017

Any clue why it was green on PR introducing this file?
#3133

@SpacePossum

This comment has been minimized.

Show comment
Hide comment
@SpacePossum

SpacePossum Oct 11, 2017

Member

I think we've no tests in place for the attrs file?

Member

SpacePossum commented Oct 11, 2017

I think we've no tests in place for the attrs file?

@keradus

This comment has been minimized.

Show comment
Hide comment
@keradus

keradus Oct 11, 2017

Member

we do, and without this PR it's failing on 2.2:
https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/builds/285237223

Member

keradus commented Oct 11, 2017

we do, and without this PR it's failing on 2.2:
https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/builds/285237223

@keradus keradus removed the RTM label Oct 13, 2017

keradus added a commit that referenced this pull request Oct 13, 2017

minor #3151 Update gitattributes to ignore next file (keradus)
This PR was squashed before being merged into the 2.2 branch (closes #3151).

Discussion
----------

Update gitattributes to ignore next file

Commits
-------

2ceb69b Update gitattributes to ignore next file

@keradus keradus closed this Oct 13, 2017

@keradus keradus deleted the keradus:2.2_fix branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment