Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodArgumentSpaceFixer - Add ensure_single_line option #3524

Conversation

julienfalque
Copy link
Member

Replaces #1980.

/cc @soullivaneuh

@julienfalque julienfalque force-pushed the function-arguments-ensure-single-line branch 2 times, most recently from 149257f to 9a1110b Compare February 10, 2018 17:49
@keradus
Copy link
Member

keradus commented Mar 20, 2018

@julienfalque , please solve conflicts ;)

@julienfalque julienfalque force-pushed the function-arguments-ensure-single-line branch 2 times, most recently from 712560c to b5ea7e4 Compare March 20, 2018 18:47
@julienfalque
Copy link
Member Author

Done. As you noticed in another PR, fabbot is asking to use long array syntax, this is weird...

@julienfalque julienfalque force-pushed the function-arguments-ensure-single-line branch 2 times, most recently from bc47568 to f4a5c04 Compare April 1, 2018 21:26
@julienfalque julienfalque force-pushed the function-arguments-ensure-single-line branch from f4a5c04 to 1ba8ee9 Compare May 16, 2018 17:53
@julienfalque julienfalque force-pushed the function-arguments-ensure-single-line branch from 1ba8ee9 to 9b8768d Compare May 28, 2018 22:27
@keradus keradus force-pushed the function-arguments-ensure-single-line branch from 9b8768d to dd4c258 Compare June 2, 2018 09:00
@keradus keradus added this to the 2.12.0 milestone Jun 2, 2018
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated PR to use new way of deprecating options

@julienfalque
Copy link
Member Author

Thanks!

@keradus keradus force-pushed the function-arguments-ensure-single-line branch from dd4c258 to 3641318 Compare June 2, 2018 16:55
@keradus
Copy link
Member

keradus commented Jun 2, 2018

Thank you @julienfalque.

@keradus keradus merged commit 3641318 into PHP-CS-Fixer:master Jun 2, 2018
keradus added a commit that referenced this pull request Jun 2, 2018
…n (julienfalque, keradus)

This PR was squashed before being merged into the 2.12-dev branch (closes #3524).

Discussion
----------

MethodArgumentSpaceFixer - Add ensure_single_line option

Replaces #1980.

/cc @soullivaneuh

Commits
-------

3641318 MethodArgumentSpaceFixer - Add ensure_single_line option
@julienfalque julienfalque deleted the function-arguments-ensure-single-line branch June 2, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants