New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MethodArgumentSpaceFixer - Add ensure_single_line option #3524
Merged
keradus
merged 1 commit into
PHP-CS-Fixer:master
from
julienfalque:function-arguments-ensure-single-line
Jun 2, 2018
Merged
MethodArgumentSpaceFixer - Add ensure_single_line option #3524
keradus
merged 1 commit into
PHP-CS-Fixer:master
from
julienfalque:function-arguments-ensure-single-line
Jun 2, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
function-arguments-ensure-single-line
branch
2 times, most recently
from
February 10, 2018 17:49
149257f
to
9a1110b
Compare
@julienfalque , please solve conflicts ;) |
julienfalque
force-pushed
the
function-arguments-ensure-single-line
branch
2 times, most recently
from
March 20, 2018 18:47
712560c
to
b5ea7e4
Compare
Done. As you noticed in another PR, fabbot is asking to use long array syntax, this is weird... |
julienfalque
force-pushed
the
function-arguments-ensure-single-line
branch
2 times, most recently
from
April 1, 2018 21:26
bc47568
to
f4a5c04
Compare
julienfalque
force-pushed
the
function-arguments-ensure-single-line
branch
from
May 16, 2018 17:53
f4a5c04
to
1ba8ee9
Compare
julienfalque
force-pushed
the
function-arguments-ensure-single-line
branch
from
May 28, 2018 22:27
1ba8ee9
to
9b8768d
Compare
keradus
force-pushed
the
function-arguments-ensure-single-line
branch
from
June 2, 2018 09:00
9b8768d
to
dd4c258
Compare
keradus
approved these changes
Jun 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated PR to use new way of deprecating options
Thanks! |
keradus
force-pushed
the
function-arguments-ensure-single-line
branch
from
June 2, 2018 16:55
dd4c258
to
3641318
Compare
Thank you @julienfalque. |
keradus
added a commit
that referenced
this pull request
Jun 2, 2018
…n (julienfalque, keradus) This PR was squashed before being merged into the 2.12-dev branch (closes #3524). Discussion ---------- MethodArgumentSpaceFixer - Add ensure_single_line option Replaces #1980. /cc @soullivaneuh Commits ------- 3641318 MethodArgumentSpaceFixer - Add ensure_single_line option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1980.
/cc @soullivaneuh