Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpdocVarWithoutNameFixer - fix for properties only #3911

Open
wants to merge 3 commits into
base: 2.12
from

Conversation

Projects
None yet
6 participants
@dmvdbrugge
Copy link
Contributor

commented Jul 13, 2018

This fixes #3112

Show resolved Hide resolved src/Fixer/Phpdoc/PhpdocVarWithoutNameFixer.php Outdated
Show resolved Hide resolved src/Fixer/Phpdoc/PhpdocVarWithoutNameFixer.php Outdated

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from c90a246 to d7771e8 Jul 13, 2018

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch 4 times, most recently from 30e75d1 to c5abd1a Jul 16, 2018

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from c5abd1a to a640dc9 Jul 16, 2018

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from a640dc9 to de4baf2 Jul 16, 2018

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from de4baf2 to 3b826a5 Jul 30, 2018

@kubawerlos

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

@keradus @ntzm can you check it and update you review status?

@ntzm

ntzm approved these changes Aug 14, 2018

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from 3b826a5 to 62d3f08 Sep 18, 2018

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from 62d3f08 to 5ee9aea Nov 13, 2018

dmvdbrugge added some commits Jul 13, 2018

PhpdocVarWithoutNameFixer - fix for properties only
Now with additional test cases and support for the `var` keyword

@dmvdbrugge dmvdbrugge force-pushed the dmvdbrugge:3112-phpdoc_var_without_name branch from 41b35ec to ec59373 Jan 7, 2019

@SpacePossum SpacePossum added the bug label Jan 11, 2019

@enumag

This comment has been minimized.

Copy link

commented May 14, 2019

Can this be merged?

@SpacePossum

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@kubawerlos or members/maintainer please review/approve as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.