New ruleset "@PhpCsFixer" #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
force-pushed
the
ruleset-phpcsfixer
branch
2 times, most recently
from
2997388
to
7899c1c
Compare
|
I think it would be great if rulesets could be concrete classes, perhaps for 3.0? |
|
👍 for this :) |
|
sounds interesting and I see ppl like it. yet, we have already some conflicts here, |
# Conflicts: # .php_cs.dist # README.rst
gharlan
force-pushed
the
ruleset-phpcsfixer
branch
from
7899c1c
to
d3c2ac9
Compare
done. |
|
Thank you @gharlan. |
keradus
added a commit
that referenced
this pull request
Dec 28, 2018
This PR was merged into the 2.12 branch. Discussion ---------- New ruleset "@PhpCsFixer" I suggest to add new rulesets "@PhpCsFixer" and "@PhpCsFixer:risky". Reason: I would like to use the standards recommended by this org. I would only add fixers to these rulesets, that are really recommended by this org, not fixers you are using because of your min php version (like list_syntax=long). Commits ------- d3c2ac9 New ruleset "@PhpCsFixer"
|
I propagated the idea up to 3.0, considering changes we done in config file on those branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to add new rulesets "@PhpCsFixer" and "@PhpCsFixer:risky".
Reason: I would like to use the standards recommended by this org.
I would only add fixers to these rulesets, that are really recommended by this org, not fixers you are using because of your min php version (like list_syntax=long).