Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some more classes final #3922

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@ntzm
Copy link
Contributor

ntzm commented Jul 15, 2018

Not Config and Finder as they are extension points.

@keradus

This comment has been minimized.

Copy link
Member

keradus commented Jul 15, 2018

-0
+1 when we will have nice rule for that

@keradus

This comment has been minimized.

Copy link
Member

keradus commented Jul 15, 2018

Rule > AutoReview
all except listed one is too demanding, nice reasoning is good to have, i won't provide full spec now, but Doctrine ORM classes shall not be final

@ntzm

This comment has been minimized.

Copy link
Contributor Author

ntzm commented Jul 15, 2018

@SpacePossum SpacePossum added the cleanup label Oct 23, 2018

@SpacePossum

This comment has been minimized.

Copy link
Member

SpacePossum commented Mar 14, 2019

I think this is RTM TBH

@SpacePossum SpacePossum added RTM and removed waiting review labels Mar 18, 2019

@SpacePossum SpacePossum added this to the 3.0.0 milestone Mar 18, 2019

@SpacePossum SpacePossum force-pushed the ntzm:make-classes-final branch from 2755fc9 to 212630b Mar 18, 2019

@SpacePossum

This comment has been minimized.

Copy link
Member

SpacePossum commented Mar 18, 2019

Thank you @ntzm.

@SpacePossum SpacePossum merged commit 212630b into FriendsOfPHP:3.0 Mar 18, 2019

1 of 4 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

SpacePossum added a commit that referenced this pull request Mar 18, 2019

minor #3922 Make some more classes final (ntzm, SpacePossum)
This PR was squashed before being merged into the 3.0 branch (closes #3922).

Discussion
----------

Make some more classes final

Not Config and Finder as they are extension points.

Commits
-------

212630b Make some more classes final

@SpacePossum SpacePossum removed the RTM label Mar 18, 2019

@ntzm

This comment has been minimized.

Copy link
Contributor Author

ntzm commented Mar 18, 2019

Thanks! I'll be contributing again soon hopefully 🤞

@ntzm ntzm deleted the ntzm:make-classes-final branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.