New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.3] NoWhitespaceBeforeCommaInArrayFixer - fix comma after heredoc-end #4191

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@gharlan
Copy link
Contributor

gharlan commented Jan 1, 2019

Input:

$a = [<<<'EOD'
foo
EOD
    , <<<'EOD'
bar
EOD
];

With PHP < 7.3 this is not changed (like before). With PHP >= 7.3 it would be changed now to:

$a = [<<<'EOD'
foo
EOD, <<<'EOD'
bar
EOD
];

@gharlan gharlan force-pushed the gharlan:heredoc-no-ws-b-comma-in-array branch 2 times, most recently from b4b1e15 to 0e2d8cd Jan 1, 2019

@kubawerlos

This comment has been minimized.

@gharlan gharlan force-pushed the gharlan:heredoc-no-ws-b-comma-in-array branch from 83f115c to 8f7ba7f Jan 1, 2019

@gharlan

This comment has been minimized.

Copy link
Contributor

gharlan commented Jan 1, 2019

@gharlan

This comment has been minimized.

Copy link
Contributor

gharlan commented Jan 1, 2019

When this pr is accepted, I will add similar PRs for some other fixers.

@gharlan gharlan force-pushed the gharlan:heredoc-no-ws-b-comma-in-array branch 2 times, most recently from 555ec0b to 90d921d Jan 1, 2019

@SpacePossum SpacePossum changed the title NoWhitespaceBeforeCommaInArrayFixer - fix comma after heredoc-end (php 7.3) [7.3] NoWhitespaceBeforeCommaInArrayFixer - fix comma after heredoc-end Jan 2, 2019

@SpacePossum SpacePossum added this to the 2.14.0 milestone Jan 2, 2019

@keradus keradus removed this from the 2.14.0 milestone Jan 4, 2019

@gharlan gharlan force-pushed the gharlan:heredoc-no-ws-b-comma-in-array branch from b0297b9 to 37e195c Jan 9, 2019

@gharlan

This comment has been minimized.

Copy link
Contributor

gharlan commented Jan 9, 2019

There is a new config option after_heredoc now.

@gharlan gharlan force-pushed the gharlan:heredoc-no-ws-b-comma-in-array branch from 37e195c to 8b7c10a Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment