Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue #4274: Let lowercase_constants directive to be configurable. #4275
Depends on #4362
This issue is to have the
Here's an example on how it would be:
lowercase_constants: case: upper
lowercase_constants: case: lower
The default would be
Why this request ?
The PHP version you are using (
dmvdbrugge left a comment
An additional note is this should target master as this is a feature and not a bugfix.
2 times, most recently
Jan 21, 2019
Hi and thanks for opening this PR.
Before I review the PR in detail, I'm wondering. The suggestion to uppercase the keywords is not in line with PSR2 , however this is part of the Drupal standard? Do you know why Drupal prefers this style or if this is legacy they might want to move away from?
No I don't know why using uppercase for keywords was chosen in Drupal.
That said, having this configurable in PHP-CS-Fixer shouldn't be a bad thing, I think.