Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullyQualifiedStrictTypesFixer - Fix the short type detection when a question mark (nullable) is prefixing it. #4303

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@drupol
Copy link
Contributor

drupol commented Feb 11, 2019

Fix #4302

@drupol drupol force-pushed the drupol:4302-fix-FullyQualifiedStrictTypesFixer-when-having-question-mark branch 4 times, most recently from 3a6f675 to 5d822c1 Feb 11, 2019

@drupol drupol changed the base branch from 2.14 to 2.12 Feb 11, 2019

@drupol drupol force-pushed the drupol:4302-fix-FullyQualifiedStrictTypesFixer-when-having-question-mark branch 4 times, most recently from d90b67f to 8e63a51 Feb 11, 2019

@drupol drupol force-pushed the drupol:4302-fix-FullyQualifiedStrictTypesFixer-when-having-question-mark branch 2 times, most recently from b042672 to 67aa6ed Feb 12, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

drupol commented Feb 12, 2019

Here's the patch for branch 2.14: https://gist.github.com/drupol/c43a4ba8712782e104194fdc015c8ede
We need it for our project.

@keradus

This comment has been minimized.

Copy link
Member

keradus commented Feb 12, 2019

thanks for the patch @drupol .
yet, to not waste your time on it, if you send a PR against older branch, after PR would be merged, that branch would also be merged into higher branch - and usually git does that without conflicts, and for small conflicts I resolve them myself.
it's very rare that for same change we ask original author to prepare independent patches for different branches - it's only in case of super complex change - in other words, don't prepare the "other branch patches" except if you was explicitly asked for ;)

@drupol

This comment has been minimized.

Copy link
Contributor Author

drupol commented Feb 12, 2019

Allrigthty!

Thanks.

@SpacePossum SpacePossum added the bug label Feb 18, 2019

@SpacePossum SpacePossum added this to the 2.12.9 milestone Feb 18, 2019

@SpacePossum SpacePossum added RTM and removed waiting review labels Mar 18, 2019

@SpacePossum SpacePossum changed the title Issue #4302: Fix the short type detection when a question mark (nullable) is prefixing it. FullyQualifiedStrictTypesFixer - Fix the short type detection when a question mark (nullable) is prefixing it. Mar 18, 2019

@SpacePossum SpacePossum force-pushed the drupol:4302-fix-FullyQualifiedStrictTypesFixer-when-having-question-mark branch from 847866c to 81b90d5 Mar 18, 2019

@SpacePossum SpacePossum force-pushed the drupol:4302-fix-FullyQualifiedStrictTypesFixer-when-having-question-mark branch from 81b90d5 to 2e9f4bb Mar 18, 2019

@SpacePossum

This comment has been minimized.

Copy link
Member

SpacePossum commented Mar 18, 2019

Thank you @drupol.

@SpacePossum SpacePossum merged commit 2e9f4bb into FriendsOfPHP:2.12 Mar 18, 2019

1 of 4 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

SpacePossum added a commit that referenced this pull request Mar 18, 2019

bug #4303 FullyQualifiedStrictTypesFixer - Fix the short type detecti…
…on when a question mark (nullable) is prefixing it. (drupol)

This PR was merged into the 2.12 branch.

Discussion
----------

FullyQualifiedStrictTypesFixer - Fix the short type detection when a question mark (nullable) is prefixing it.

Fix #4302

Commits
-------

2e9f4bb Issue #4302: Fix the short type detection when a question mark (nullable) is prefixing it.

@SpacePossum SpacePossum removed the RTM label Mar 18, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

drupol commented Mar 18, 2019

Thanks ! Very needed here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.