Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4309: Fix FullyQualifiedStrictTypesFixer when classes has an extends type #4310

Open
wants to merge 8 commits into
base: 2.15
from

Conversation

@drupol
Copy link
Contributor

commented Feb 13, 2019

Fix #4309

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from a4ec32c to a19673f Feb 13, 2019

@drupol drupol changed the base branch from 2.14 to 2.12 Feb 13, 2019

@drupol drupol force-pushed the drupol:4309-shorten-extends branch 8 times, most recently from 80de1c3 to 495aef9 Feb 13, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@keradus or @dmvdbrugge Could you help with the failing test on Travis ? I don't think it's related to this pull request. Thanks.

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from 495aef9 to c5357e3 Feb 13, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

@SpacePossum Do you have the opportunity to review this ?

@SpacePossum

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

sorry man, I'm hopelessly behind with anything related to open source : (

@drupol drupol force-pushed the drupol:4309-shorten-extends branch 2 times, most recently from 8e6224e to 4791461 Mar 3, 2019

@keradus

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

in future, please try avoid force-pushes, hard to review when you don't know what changed and need to review everything from scratch

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from 4791461 to 777e394 Apr 6, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Working on this for the #EUFOSSA Hackaton initiative.

More info: https://ec.europa.eu/info/news/co-creating-future-open-source-eu-fossa-2-hackathons-2019-mar-21_sl

@drupol drupol force-pushed the drupol:4309-shorten-extends branch 2 times, most recently from 2295595 to a176e56 Apr 6, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I did a force-push to rebase the branch against latest 2.12 branch, nothing has changed since the last review.

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from a176e56 to 59dbc16 Jul 22, 2019

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

I just rebased the branch against the latest changes in branch 2.12.

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

@SpacePossum I need your review :-)

@drupol drupol force-pushed the drupol:4309-shorten-extends branch 2 times, most recently from bbc3080 to 24d1df5 Jul 27, 2019

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from 45464bf to 24d1df5 Jul 28, 2019

@keradus keradus changed the base branch from 2.12 to 2.15 Sep 4, 2019

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from 24d1df5 to f52d348 Sep 10, 2019

@drupol drupol force-pushed the drupol:4309-shorten-extends branch from f52d348 to e9c188b Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.