Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache - add indent and line ending to cache signature #4335

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@dmvdbrugge
Copy link
Contributor

dmvdbrugge commented Mar 15, 2019

Add indent and line ending to cache signature

Fixes #4330

@SpacePossum SpacePossum added the bug label Mar 15, 2019

@SpacePossum SpacePossum added this to the 2.12.9 milestone Mar 15, 2019

@SpacePossum

This comment has been minimized.

Copy link
Member

SpacePossum commented Mar 15, 2019

Thanks for the PR. Looks good to me, all changes are on internal classes/interfaces so no BC breaks :)

@localheinz could you take a look as well as author of the original cache files?

@localheinz
Copy link
Contributor

localheinz left a comment

👍

Show resolved Hide resolved tests/Cache/FileHandlerTest.php Outdated

@SpacePossum SpacePossum added the RTM label Mar 15, 2019

@SpacePossum SpacePossum changed the title Add indent and line ending to cache signature Cache - add indent and line ending to cache signature Mar 18, 2019

@SpacePossum SpacePossum force-pushed the dmvdbrugge:4330-fix-cache branch from e956cae to 739adcf Mar 18, 2019

@SpacePossum

This comment has been minimized.

Copy link
Member

SpacePossum commented Mar 18, 2019

Thank you @dmvdbrugge.

@SpacePossum SpacePossum merged commit 739adcf into FriendsOfPHP:2.12 Mar 18, 2019

1 of 4 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

SpacePossum added a commit that referenced this pull request Mar 18, 2019

bug #4335 Cache - add indent and line ending to cache signature (dmvd…
…brugge)

This PR was squashed before being merged into the 2.12 branch (closes #4335).

Discussion
----------

Cache - add indent and line ending to cache signature

Add indent and line ending to cache signature

Fixes #4330

Commits
-------

739adcf Cache - add indent and line ending to cache signature

@SpacePossum SpacePossum removed the RTM label Mar 18, 2019

@dmvdbrugge dmvdbrugge deleted the dmvdbrugge:4330-fix-cache branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.