[7.3] MethodArgumentSpaceFixer - fix comma after heredoc-end #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gharlan
force-pushed
the
method-argument-space-heredoc
branch
from
0d04a0e
to
e3c63ae
Compare
|
Thank you @gharlan. |
SpacePossum
added a commit
that referenced
this pull request
Mar 19, 2019
…c-end (gharlan)
This PR was merged into the 2.15-dev branch.
Discussion
----------
[7.3] MethodArgumentSpaceFixer - fix comma after heredoc-end
Input:
```php
foo(
<<<'EOD'
bar
EOD
,
'baz'
);
```
With PHP 7.3 and new config option `after_heredoc` it is fixed to:
```php
foo(
<<<'EOD'
bar
EOD,
'baz'
);
```
(similar to #4191)
Commits
-------
e3c63ae [7.3] MethodArgumentSpaceFixer - fix comma after heredoc-end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input:
With PHP 7.3 and new config option
after_heredocit is fixed to:(similar to #4191)