Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4361: Implements the ClassAnalyzer and its tests. #4362

Open
wants to merge 10 commits into
base: 2.15
from

Conversation

@drupol
Copy link
Contributor

commented Apr 6, 2019

Fix #4361

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

I just rebased the branch against latest 2.12 branch.

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

This needs more work. I will finish it tonight.

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

This is now ready for another round of review.

@SpacePossum @keradus @dmvdbrugge @localheinz

tests/Tokenizer/Analyzer/ClassAnalyzerTest.php Outdated Show resolved Hide resolved
tests/Tokenizer/Analyzer/ClassAnalyzerTest.php Outdated Show resolved Hide resolved
src/Tokenizer/Analyzer/ClassAnalyzer.php Outdated Show resolved Hide resolved
src/Tokenizer/Analyzer/ClassAnalyzer.php Outdated Show resolved Hide resolved

@drupol drupol force-pushed the drupol:4361-implements-classanalyzer branch from b35886e to 65f5040 Jul 27, 2019

@kubawerlos

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2019

In Tokenizer/Analyzer we have ArgumentsAnalyzer, CommentsAnalyzer and so on - I mean have plural names - therefore can we rename this analyzer to ClassesAnalyzer?

@drupol

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

In Tokenizer/Analyzer we have ArgumentsAnalyzer, CommentsAnalyzer and so on - I mean have plural names - therefore can we rename this analyzer to ClassesAnalyzer?

Fair enough. Done!

@keradus keradus changed the base branch from 2.12 to 2.15 Sep 4, 2019

@drupol drupol force-pushed the drupol:4361-implements-classanalyzer branch from c4e4d13 to d404dcd Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.