PHP7.4 - Add "str_split" => "mb_str_split" mapping. #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
approved these changes
Apr 16, 2019
SpacePossum
added a commit
that referenced
this pull request
Apr 17, 2019
…ePossum) This PR was merged into the 2.12 branch. Discussion ---------- PHP7.4 - Add "str_split" => "mb_str_split" mapping. @ see https://wiki.php.net/rfc/mb_str_split Commits ------- 7ef0040 PHP7.4 - Add "str_split" => "mb_str_split" mapping.
keradus
reviewed
Aug 31, 2019
| $functions = array_filter( | ||
| self::$functionsMap, | ||
| static function ($mapping) { | ||
| return \function_exists($mapping['alternativeName']); |
There was a problem hiding this comment.
this was causing the issue. when we execute this, it's always truth, as we have the mb polyfill on execution time...
SpacePossum
added a commit
that referenced
this pull request
Oct 9, 2019
…keradus, Slamdunk) This PR was merged into the 2.15 branch. Discussion ---------- Redo PHP7.4 - Add "str_split" => "mb_str_split" mapping This reverts commit d35c431. Reapply #4380 by reverting #4533 Commits ------- 083d062 mb_*: rely on ReflectionFunction::isInternal to detect correct list of functions to fix 3fea39f Revert "Revert PHP7.4 - Add \"str_split\" => \"mb_str_split\" mapping"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ see https://wiki.php.net/rfc/mb_str_split