Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionsAnalyzer - add "isTheSameClassCall" for correct verifying of function calls #4476

Open

Conversation

@kubawerlos
Copy link
Contributor

kubawerlos commented Jul 26, 2019

No description provided.

*
* @return bool
*/
public function isTheSameClassCall(Tokens $tokens, $index)

This comment has been minimized.

Copy link
@SpacePossum

SpacePossum Jul 29, 2019

Member

I like the PR as a good clean up, I'm not sure about the name of this method though.
Also, not sure about adding a new method to this class following the reasoning here, maybe a new analyzer would be a better fit?

This comment has been minimized.

Copy link
@kubawerlos

kubawerlos Jul 29, 2019

Author Contributor

I'm open for suggestion for new names (analyzer and method) ;)

MethodssAnalyzer? the function name is the best I can think of.

This comment has been minimized.

Copy link
@julienfalque

julienfalque Oct 23, 2019

Member

This class is @internal so I think adding this method here is fine.

@keradus keradus changed the base branch from 2.12 to 2.15 Sep 4, 2019
@kubawerlos kubawerlos force-pushed the kubawerlos:fix-same-class-calls-for-different-case branch from d875877 to bd2c644 Oct 23, 2019
@keradus keradus force-pushed the kubawerlos:fix-same-class-calls-for-different-case branch from 4a99622 to e1426c0 Nov 2, 2019
@kubawerlos kubawerlos force-pushed the kubawerlos:fix-same-class-calls-for-different-case branch from e1426c0 to b77e07b Nov 7, 2019
@kubawerlos kubawerlos force-pushed the kubawerlos:fix-same-class-calls-for-different-case branch from b77e07b to fe5d570 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.