Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow PHP 7.4 failures on Travis CI #4622

Merged

Conversation

@julienfalque
Copy link
Member

julienfalque commented Nov 3, 2019

PHP bug has been closed. Looks like the actual bug was in mikey179/vfsstream (bovigo/vfsStream#204). The fix has been merged and released so we can now disallow Travis CI failures.

@julienfalque julienfalque added this to the 2.15.4 milestone Nov 3, 2019
@keradus keradus modified the milestones: 2.15.4, 2.15.5 Nov 3, 2019
@julienfalque julienfalque force-pushed the julienfalque:travis-disallow-php-7.4-failures branch from 60b416c to 5e93aa9 Nov 7, 2019
@kubawerlos

This comment has been minimized.

Copy link
Contributor

kubawerlos commented Nov 7, 2019

Shouldn't we update composer.json with:

         "justinrainbow/json-schema": "^5.0",
         "keradus/cli-executor": "^1.2",
-        "mikey179/vfsstream": "^1.6",
+        "mikey179/vfsstream": "^1.6.8",
         "php-coveralls/php-coveralls": "^2.1",
         "php-cs-fixer/accessible-object": "^1.0",

or is it overkill?

If we had Travis job with PHP 7.4 and COMPOSER_FLAGS="--prefer-lowest" it would fail.

@julienfalque

This comment has been minimized.

Copy link
Member Author

julienfalque commented Nov 7, 2019

For now it doesn't fail so I'd say it's fine.

@julienfalque julienfalque added the RTM label Nov 14, 2019
julienfalque added a commit that referenced this pull request Nov 19, 2019
This PR was merged into the 2.15 branch.

Discussion
----------

Disallow PHP 7.4 failures on Travis CI

[PHP bug](https://bugs.php.net/bug.php?id=78575) has been closed. Looks like the actual bug was in `mikey179/vfsstream` (bovigo/vfsStream#204). The fix has been merged and released so we can now disallow Travis CI failures.

Commits
-------

5e93aa9 Disallow PHP 7.4 failures on Travis CI
@julienfalque julienfalque merged commit 5e93aa9 into FriendsOfPHP:2.15 Nov 19, 2019
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@julienfalque julienfalque deleted the julienfalque:travis-disallow-php-7.4-failures branch Nov 19, 2019
@kubawerlos

This comment has been minimized.

Copy link
Contributor

kubawerlos commented Nov 19, 2019

Thank you @julienfalque .

@julienfalque julienfalque removed the RTM label Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.