NativeConstantInvocationFixer - add "strict" flag #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
reviewed
Dec 18, 2019
SpacePossum
approved these changes
Dec 18, 2019
|
Im very much 👍 for adding to the SF set |
|
Me too: |
julienfalque
reviewed
Jan 6, 2020
julienfalque
approved these changes
Jan 6, 2020
|
Thank you @kubawerlos. |
SpacePossum
added a commit
that referenced
this pull request
Jan 7, 2020
…werlos) This PR was merged into the 2.17-dev branch. Discussion ---------- NativeConstantInvocationFixer - add "strict" flag @nicolas-grekas is it OK to add it to `@Symfony` rule set (I did it as it is very similar "strict" as for `NativeFunctionInvocationFixer`)? Commits ------- 74aae91 NativeConstantInvocationFixer - add "strict" flag
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicolas-grekas is it OK to add it to
@Symfonyrule set (I did it as it is very similar "strict" as forNativeFunctionInvocationFixer)?