Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Sf5 compatibility #4685

Open
wants to merge 1 commit into
base: 2.15
from
Open

Better Sf5 compatibility #4685

wants to merge 1 commit into from

Conversation

@keradus
Copy link
Member

keradus commented Dec 2, 2019

Closes #4684

one can install contract on his own, even if he is using Sf version that does not rely on contracts,
for that, we need to check if actually Sf component relies on contract, not only the fact that contract exists.

TODO:

  • look for other places when we check that contract exists and nothing more
@kbond

This comment has been minimized.

Copy link

kbond commented Dec 2, 2019

I can confirm this fixes the issue. Here is my reproducer: https://github.com/kbond/php-cs-fixer-2.16.1-reproducer

@kbond
kbond approved these changes Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.