Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase PHPStan level to 3 #4791

Open
wants to merge 2 commits into
base: 2.15
from
Open

Conversation

@julienfalque
Copy link
Member

julienfalque commented Feb 9, 2020

No description provided.

@julienfalque julienfalque force-pushed the julienfalque:phpstan branch from 023fe4d to 1820aba Feb 9, 2020
@julienfalque julienfalque changed the title Increase PHPStan level to 2 Increase PHPStan level to 3 Feb 9, 2020
src/Console/Application.php Outdated Show resolved Hide resolved
src/Console/Command/DescribeCommand.php Outdated Show resolved Hide resolved
@SpacePossum SpacePossum added this to the 2.15.6 milestone Feb 11, 2020
@SpacePossum SpacePossum added the RTM label Feb 11, 2020
@julienfalque julienfalque removed the RTM label Feb 11, 2020
@julienfalque

This comment has been minimized.

Copy link
Member Author

julienfalque commented Feb 11, 2020

Removing the RTM label as we do need to resolve the issue with Travis CI first.

@SpacePossum

This comment has been minimized.

Copy link
Member

SpacePossum commented Feb 11, 2020

isn't that the key issue and not related to this PR?

@julienfalque

This comment has been minimized.

Copy link
Member Author

julienfalque commented Feb 11, 2020

I don't think it's a consequence of changes in this PR but it prevents us to make sure the one thing we want to see working actually works :)

@julienfalque julienfalque force-pushed the julienfalque:phpstan branch from c36b319 to 1aa4310 Feb 12, 2020
@julienfalque julienfalque force-pushed the julienfalque:phpstan branch from 1aa4310 to de12f12 Feb 12, 2020

public function testGetMajorVersion()
{
static::assertSame(2, Application::getMajorVersion());

This comment has been minimized.

Copy link
@SpacePossum

SpacePossum Feb 16, 2020

Member

this will break on v3, maybe better to make it dynamic;

    public function testGetMajorVersion()
    {
        $majorVersion = Application::getMajorVersion();
        self::assertInternalType('int', $majorVersion);
        self::assertGreaterThanOrEqual(2, $majorVersion);
        static::assertRegExp(sprintf('#^%d\.\d{1,2}\.\d{1,2}-[A-Z]+.*$#', $majorVersion), Application::VERSION);
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.