This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Use PHP CS Fixer and update .travis.yml #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
force-pushed
the
php-cs-fixer
branch
3 times, most recently
from
5ce92e3
to
558479d
Compare
|
Travis passes, fabbot fixed here: #119 |
|
|
||
| install: | ||
| - travis_retry composer install --no-interaction --prefer-source | ||
| - vendor/bin/php-cs-fixer --diff --dry-run fix . |
There was a problem hiding this comment.
This is already run by fabbot, so no need to do it here as well.
There was a problem hiding this comment.
I can't see any docs for fabbot :(
There was a problem hiding this comment.
I removed PHP CS Fixer tool from deps and .travis.yml.
I do not understand how it is runned by fabbot and still so many changes was done here by PHP CS Fixer that fabbot does not complain about ?
There was a problem hiding this comment.
Because fabbot did not exist when we started the project and because we run it on PR but did not necesseraly enforce it before merging.
There was a problem hiding this comment.
I see, thanks.
BTW, is there any docs for fabbot?
keradus
force-pushed
the
php-cs-fixer
branch
from
558479d
to
ee068cb
Compare
|
Thank you @keradus. |
fabpot
added a commit
that referenced
this pull request
Nov 17, 2014
This PR was merged into the master branch. Discussion ---------- Use PHP CS Fixer and update .travis.yml Commits ------- ee068cb Use PHP CS Fixer and update .travis.yml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.