Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a wrong file #414

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@leofeyer
Copy link
Contributor

commented Oct 7, 2019

The file was actually a duplicate of https://github.com/FriendsOfPHP/security-advisories/blob/master/contao/core/CVE-2018-5478.yaml with wrong information in it.

The file was actually a duplicate of https://github.com/FriendsOfPHP/security-advisories/blob/master/contao/core/CVE-2018-5478.yaml with wrong information in it.
@stof

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

the page at https://contao.org/en/news/contao-3_5_32.html seems to indicate this is not wrong:

The problem affects Contao 2.0.0 to 3.5.31 and the Contao newsletter bundle 4.0.0 to 4.0.3.

@leofeyer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

@stof I have updated the information on contao.org (see https://contao.org/en/news/contao-3_5_32.html).

@leofeyer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Also, the CVE number is from 2018 and Contao 4.0.4 has been released in October 2015. The numbers clearly do not add up here, do they?

@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

I'm going to trust @leofeyer and merge this one.

@fabpot fabpot merged commit c151f9d into FriendsOfPHP:master Oct 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.