Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle is not compatible with ruflin/elastica 7.0.0-beta1 #1568

Open
deguif opened this issue Nov 1, 2019 · 9 comments
Open

Bundle is not compatible with ruflin/elastica 7.0.0-beta1 #1568

deguif opened this issue Nov 1, 2019 · 9 comments

Comments

@deguif
Copy link
Contributor

@deguif deguif commented Nov 1, 2019

As there were some breaking introduced in ruflin/elastica 7.x branch with the Elastica\Type removal, I think support for version 7.x of ruflin/elastica in composer.json should be removed.

By the way, I would be very happy to help making this bundle compatible with ruflin/elastica 7.x version. But it would probably require to create a new branch, as there are quite a lot of changes to do.

@deguif

This comment has been minimized.

Copy link
Contributor Author

@deguif deguif commented Nov 1, 2019

See ruflin/Elastica#1666 for reference

@thomaspicquet

This comment has been minimized.

Copy link

@thomaspicquet thomaspicquet commented Nov 2, 2019

I'm not sure if there are any plans on supporting the new version ruflin/elastica. This bundle doesn't seem updated anymore

@XWB

This comment has been minimized.

Copy link
Member

@XWB XWB commented Nov 2, 2019

@deguif You are right. I created a 5.1.x branch and removed ruflin/elastica 7 from the composer file. In addition, master has been bumped, allowing us to introduce BC breaks. Feel free to open a PR with proper ruflin/elastica 7 support :)

@thomaspicquet Pull requests are still welcome. If you want new functionality, feel free to open a PR :)

@OskarStark

This comment has been minimized.

Copy link
Contributor

@OskarStark OskarStark commented Nov 3, 2019

So we can handle #1566 with a BC break, too?

@deguif

This comment has been minimized.

Copy link
Contributor Author

@deguif deguif commented Nov 3, 2019

@OskarStark that would mean dropping support for Symfony 3.4 in master and support only Symfony 4.3+, if I understand correctly?

@deguif

This comment has been minimized.

Copy link
Contributor Author

@deguif deguif commented Nov 3, 2019

@XWB Shouldn't we bump the new version of the bundle to 7.0 instead of 6.0, to better reflect we support ruflin/elastica 7.x in this major version?

@OskarStark

This comment has been minimized.

Copy link
Contributor

@OskarStark OskarStark commented Nov 3, 2019

@OskarStark that would mean dropping support for Symfony 3.4 in master and support only Symfony 4.3+, if I understand correctly?

Yes 👍

@deguif

This comment has been minimized.

Copy link
Contributor Author

@deguif deguif commented Nov 3, 2019

I would love to get rid of Symfony 3.4, but as Symfony 3.4 is a LTS and its end of support is only for end of next year, it maybe not judicious?

@deguif

This comment has been minimized.

Copy link
Contributor Author

@deguif deguif commented Nov 7, 2019

I started to work on this topic, but will probably take a long time
See #1569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.