Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Trigger a deprecation call in FOQElasticaBundle #258

Closed
merk opened this Issue Mar 27, 2013 · 5 comments

Comments

Projects
None yet
3 participants
Owner

merk commented Mar 27, 2013

FOQElasticaBundle should indicate to users in a nice way that it should be migrated

  • Find a suitable location to trigger an E_USER_DEPRECATED error (Bundle#boot and Extension#load are not suitable)
  • Document the migration as a separate document that can be linked
Owner

jmikola commented Mar 27, 2013

Cross-referencing with earlier discussion in FriendsOfSymfony/friendsofsymfony.github.com#37

Owner

jmikola commented Mar 27, 2013

One caveat here is that some users may want to continue using FOQElasticaBundle as-is (I don't expect Exercise to migrate right away), and we shouldn't force a deprecation notice for them (e.g. if we added this to one of the core class constructors). Since there are no tags on the original repository, many users are tracking the 2.0 and master branches, so it would be impossible to implement this kind of notice without forcing it upon them.

Owner

merk commented Mar 27, 2013

Triggering of deprecation warnings wont mean that they cant continue to use the bundle, it means the WDT will alert them that there is a deprecation. While I understand that people will be using the FOQ bundle and tracking different points, ultimately the goal will be to deprecate the bundle.

Maybe we should tag final versions of FOQElasticaBundle prior to implementing something like this so that those who wish to can continue to use it without maintenance.

Owner

stof commented Mar 28, 2013

@merk 2.1 users would get an exception for the deprecation

Owner

merk commented Mar 28, 2013

version_compare(Kernel::VERSION, '2.2.0', '>=') with VERSION < 2.2.0 returns false, I think it should still be done. It gives us a method of communicating with more moderately up to date framework users that the bundle moved.

@merk merk closed this Jul 3, 2014

@tumbochka tumbochka pushed a commit to formapro-forks/FOSElasticaBundle that referenced this issue Jul 17, 2014

@jeremymarc jeremymarc Merge pull request #258 from Remixjobs/form-error-fix
Fix position of error elements
d660824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment