From 2a8ec179d5033db6ecb4b2e5ad6daf96ae328a61 Mon Sep 17 00:00:00 2001 From: David Buchmann Date: Sun, 31 May 2015 14:31:08 +0200 Subject: [PATCH] fix AppKernel and no longer skip symfony cache client tests with hhvm --- tests/Functional/Fixtures/Symfony/AppKernel.php | 13 +++++++++---- tests/Functional/SymfonyProxyClientTest.php | 14 -------------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/tests/Functional/Fixtures/Symfony/AppKernel.php b/tests/Functional/Fixtures/Symfony/AppKernel.php index d41df53d..e518a286 100644 --- a/tests/Functional/Fixtures/Symfony/AppKernel.php +++ b/tests/Functional/Fixtures/Symfony/AppKernel.php @@ -4,13 +4,18 @@ use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Response; -use Symfony\Component\HttpKernel\HttpKernel; use Symfony\Component\HttpKernel\HttpKernelInterface; -class AppKernel extends HttpKernel +/** + * A simplistic kernel that is actually the whole application. + */ +class AppKernel implements HttpKernelInterface { - public function __construct() {} - + /** + * This simplistic kernel handles the request immediately inline. + * + * {@inheritDoc} + */ public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQUEST, $catch = true) { switch ($request->getPathInfo()) { diff --git a/tests/Functional/SymfonyProxyClientTest.php b/tests/Functional/SymfonyProxyClientTest.php index 2c35e823..d4561a20 100644 --- a/tests/Functional/SymfonyProxyClientTest.php +++ b/tests/Functional/SymfonyProxyClientTest.php @@ -20,20 +20,6 @@ */ class SymfonyProxyClientTest extends SymfonyTestCase { - public function setUp() - { - /* - * We did not figure out how to run this test with hhvm. Help welcome! - * On travis, connection is closed after the headers are sent without providing - * anything in either the hhvm or apache log. - */ - if (defined('HHVM_VERSION')) { - $this->markTestSkipped('Test not working with hhvm as backend server'); - } - - parent::setUp(); - } - public function testPurge() { $this->assertMiss($this->getResponse('/symfony.php/cache'));