Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update to PHPUnit 5.4+/6.x #365
As discussed in #363, this PR aims to migrate to PHPUnit 5.4, so it will be also cross compatible with PHPUnit 6.
The hardest part was migrating the
i made some progress :-D in 94d5de0 i tried to alias the phpunit TestListener interface to something else. it looks to me like the class_alias functionality merges the
use statements from both files or something like that.
then in a25974e i tried to find a solution for a phpunit exception that is not forward compatible.
https://travis-ci.org/FriendsOfSymfony/FOSHttpCache/builds/266238016 looks a lot better. lowest version fails. can you bump the lowest version to one that has the forward compatible interfaces? i guess that should be 5.6 or 5.7.
@hpatoio we get build errors because frickle.com times out. they are the ones providing the purge extension for nginx... do you know them, would you know if they discontinued delivering the nginx extension or if its just a technical problem and they will fix their servers?
there is #344 which is about adding a docker file. i think that would be the way forward, also to be able to install the varnish xkey plugin in #332 so that we could test that... but it seems that #344 has stalled. if you want to pick it up, i'd be happy. i'd prefer having slower build over having to host a custom docker image somewhere that then needs to be rebuilt and re-uploaded manually when one of the vendors changes.