Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate context after switch user #510

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@onEXHovia
Copy link
Contributor

onEXHovia commented Dec 20, 2018

Closes #506

I added some tests, but not sure that fully covered this feature. Let me know if need to add something. Thanks!

@onEXHovia onEXHovia force-pushed the onEXHovia:switch-user branch from 73e2540 to 2a0a7f2 Dec 20, 2018

@dbu

dbu approved these changes Dec 20, 2018

Copy link
Contributor

dbu left a comment

great job, thanks!

i think we don't need this in the documentation, but should have a phpdoc on the listener class. and can you please add an entry to the changlog (i'd put it as "fix" because we consider it a fix)

use Symfony\Component\Security\Http\Event\SwitchUserEvent;
use Symfony\Component\Security\Http\SecurityEvents;
class SwitchUserListener implements EventSubscriberInterface

This comment has been minimized.

Copy link
@dbu

dbu Dec 20, 2018

Contributor

can you add a phpdoc with the explanation why we do this? (basically the TLDR of our discussion in the issue you reported)

@dbu

This comment has been minimized.

Copy link
Contributor

dbu commented Mar 12, 2019

i added the changelog and phpdoc and merged manually. thanks again for the contribution!

@dbu dbu closed this Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.