add support for nginx #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not tested in a real project however. |
|
Nice! Can you also add a doc chapter? |
| @@ -255,6 +255,28 @@ private function addProxyClientSection(ArrayNodeDefinition $rootNode) | |||
| ->end() | |||
| ->end() | |||
| ->end() | |||
|
|
|||
| ->arrayNode('nginx') | |||
| ->children() | |||
There was a problem hiding this comment.
you miss the call ->fixXmlConfig('server')
| Configuration | ||
| ============= | ||
|
|
||
| Debug Header |
There was a problem hiding this comment.
moved from the proxy client config. does not belong into any section really. should i move it to the end of this file?
There was a problem hiding this comment.
Why doesn't it belong in proxy client config?
There was a problem hiding this comment.
the proxy client sends requests to the proxy. the debug header setting wants to add a header to responses - its handled by the cache header subscriber as its closest to that one.
|
@dbu Does this need more testing or do you just want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #74