Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

missing xsd file #343

Open
lsmith77 opened this Issue Dec 16, 2012 · 10 comments

Comments

Projects
None yet
6 participants
Owner

lsmith77 commented Dec 16, 2012

@everzet: did we ever have an XSD file?

in our fixtures we seem to assume so:

<routes xmlns="http://friendsofsymfony.github.com/schema/rest"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://friendsofsymfony.github.com/schema/rest http://friendsofsymfony.github.com/schema/rest/routing-1.0.xsd">

https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/jobs/3687051

@Tobion: i assume we are not seeing those errors because of the loader refactoring in the routing component?

@everzet everzet was assigned Dec 16, 2012

Member

Tobion commented Dec 16, 2012

I would recommend to reuse the symfony namespace and xsd for route elements/attributes that are already defined there. And only add custom attributes in the fos namespace. This is usually how namespaced should be used.
I also fixed the symfony xml loader to accepts namespace prefixes, so its really compatible with xml. So there should be no problem in mixing namespaces.

@hason hason referenced this issue in symfony/symfony Dec 17, 2012

Closed

[Router] Fixed test #6393

Owner

everzet commented Dec 17, 2012

👍 to @Tobion proposal. I don't have hard opinion here as i'm using yml for routes. That's probably the reason why it wasn't been done correct in the first place :)

Owner

lsmith77 commented Jan 2, 2013

so the issue is fixed .. leaving the ticket open for anyone who wants to do the xsd clean up.

Contributor

mvrhov commented Jan 3, 2013

@lsmith77 it seems that I have fixed the issue. I don't know if we still need the patch in symfony.
@hason: Will you remove the PR from symfony repo?

Owner

lsmith77 commented Jan 3, 2013

well it was a BC break that wasnt supposed to happen.

Owner

lsmith77 commented Mar 13, 2013

@Elexy another ticket you could have a look at.

Elexy commented Mar 13, 2013

Sorry not until next week

domnikl commented Sep 4, 2013

👍 on adding XSDs for all configuration settings, not only for routes

Owner

lsmith77 commented Sep 4, 2013

happy to merge a PR for this :)

@lsmith77 lsmith77 modified the milestone: 1.8, 1.7 Jul 10, 2015

@lsmith77 lsmith77 modified the milestone: 1.7, 1.8 Aug 9, 2015

@lsmith77 lsmith77 modified the milestone: 1.8, 2.0 Aug 29, 2015

@lsmith77 lsmith77 modified the milestone: 2.0 Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment