missing xsd file #343

Open
lsmith77 opened this Issue Dec 16, 2012 · 10 comments

Comments

Projects
None yet
6 participants
@lsmith77
Owner

lsmith77 commented Dec 16, 2012

@everzet: did we ever have an XSD file?

in our fixtures we seem to assume so:

<routes xmlns="http://friendsofsymfony.github.com/schema/rest"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://friendsofsymfony.github.com/schema/rest http://friendsofsymfony.github.com/schema/rest/routing-1.0.xsd">

https://travis-ci.org/FriendsOfSymfony/FOSRestBundle/jobs/3687051

@Tobion: i assume we are not seeing those errors because of the loader refactoring in the routing component?

@ghost ghost assigned everzet Dec 16, 2012

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Dec 16, 2012

Owner
@Tobion

This comment has been minimized.

Show comment Hide comment
@Tobion

Tobion Dec 16, 2012

Member

I would recommend to reuse the symfony namespace and xsd for route elements/attributes that are already defined there. And only add custom attributes in the fos namespace. This is usually how namespaced should be used.
I also fixed the symfony xml loader to accepts namespace prefixes, so its really compatible with xml. So there should be no problem in mixing namespaces.

Member

Tobion commented Dec 16, 2012

I would recommend to reuse the symfony namespace and xsd for route elements/attributes that are already defined there. And only add custom attributes in the fos namespace. This is usually how namespaced should be used.
I also fixed the symfony xml loader to accepts namespace prefixes, so its really compatible with xml. So there should be no problem in mixing namespaces.

@hason hason referenced this issue in symfony/symfony Dec 17, 2012

Closed

[Router] Fixed test #6393

@everzet

This comment has been minimized.

Show comment Hide comment
@everzet

everzet Dec 17, 2012

Owner

👍 to @Tobion proposal. I don't have hard opinion here as i'm using yml for routes. That's probably the reason why it wasn't been done correct in the first place :)

Owner

everzet commented Dec 17, 2012

👍 to @Tobion proposal. I don't have hard opinion here as i'm using yml for routes. That's probably the reason why it wasn't been done correct in the first place :)

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Jan 2, 2013

Owner

so the issue is fixed .. leaving the ticket open for anyone who wants to do the xsd clean up.

Owner

lsmith77 commented Jan 2, 2013

so the issue is fixed .. leaving the ticket open for anyone who wants to do the xsd clean up.

@mvrhov

This comment has been minimized.

Show comment Hide comment
@mvrhov

mvrhov Jan 3, 2013

Contributor

@lsmith77 it seems that I have fixed the issue. I don't know if we still need the patch in symfony.
@hason: Will you remove the PR from symfony repo?

Contributor

mvrhov commented Jan 3, 2013

@lsmith77 it seems that I have fixed the issue. I don't know if we still need the patch in symfony.
@hason: Will you remove the PR from symfony repo?

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Jan 3, 2013

Owner

well it was a BC break that wasnt supposed to happen.

Owner

lsmith77 commented Jan 3, 2013

well it was a BC break that wasnt supposed to happen.

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Mar 13, 2013

Owner

@Elexy another ticket you could have a look at.

Owner

lsmith77 commented Mar 13, 2013

@Elexy another ticket you could have a look at.

@Elexy

This comment has been minimized.

Show comment Hide comment
@Elexy

Elexy Mar 13, 2013

Sorry not until next week

Elexy commented Mar 13, 2013

Sorry not until next week

@domnikl

This comment has been minimized.

Show comment Hide comment
@domnikl

domnikl Sep 4, 2013

👍 on adding XSDs for all configuration settings, not only for routes

domnikl commented Sep 4, 2013

👍 on adding XSDs for all configuration settings, not only for routes

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Sep 4, 2013

Owner

happy to merge a PR for this :)

Owner

lsmith77 commented Sep 4, 2013

happy to merge a PR for this :)

@lsmith77 lsmith77 modified the milestones: 1.8, 1.7 Jul 10, 2015

@lsmith77 lsmith77 modified the milestones: 1.7, 1.8 Aug 9, 2015

@lsmith77 lsmith77 modified the milestones: 1.8, 2.0 Aug 29, 2015

@lsmith77 lsmith77 modified the milestone: 2.0 Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment