clean up ViewListener code due to FrameworkExtraBundle PR merge #412

Closed
jrobeson opened this Issue Mar 27, 2013 · 9 comments

5 participants

@vkartaviy

👍

@stof
FriendsOfSymfony member

be careful. It has been merged only for Symfony 2.3 (yeah, SensioFrameworkExtraBundle maintains 3 separate branches with a compatible code base in all of them, except the composer constraints)

@jrobeson jrobeson referenced this issue in sensiolabs/SensioFrameworkExtraBundle Apr 2, 2013
Closed

Last commit break @Template #210

@jrobeson

@stof: how come the composer constraint isn't updated to 2.3-dev ? Pardon my ignorance and assumptions on that one.

@lsmith77
FriendsOfSymfony member

the branch wasnt around when i last updated the composer.json. this is quite a messy situation. i hope we will not need a branch just to deal with this.

@skydiablo

ok, sry for my useless comment, but what can i do to around this error ?

@lsmith77
FriendsOfSymfony member

maybe the best solution is to just duplicate the code and get rid of the sensio dependency entirely.

@lsmith77
FriendsOfSymfony member

btw .. i havent analyzed the issue at all yet and since i dont really use the view response listener the motivation to invest the time is a bit low given the OSS things i can work on.

@jrobeson

tthe branch was merged, so 2.2.* deps on sensio/frameworkextrabundle should work again. I'll see about updating the listener code in the next day or so.

@lsmith77
FriendsOfSymfony member

thanks .. then we can also enable 2.3-dev aka master testing again.

@lsmith77 lsmith77 closed this May 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment