Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Travis CI job using Symfony 5 components #2084

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@xabbuh
Copy link
Member

xabbuh commented Feb 7, 2020

No description provided.

@xabbuh xabbuh added this to the 3.0 milestone Feb 7, 2020
@xabbuh xabbuh force-pushed the xabbuh:symfony5-compat branch from a7bb5ec to 45bde25 Feb 7, 2020
@Tobion

This comment has been minimized.

Copy link
Member

Tobion commented Feb 7, 2020

I've seen you started working on SF 5 compatibility.
Do you have a plan already what is going to get removed in version 3?

For example, I wonder what the whole templating part has to do in a rest-bundle? Can't we just say if you want to render html etc with templating, then do not use the view handler system of the rest-bundle? Then there is no point in having any templating logic in a rest-bundle or am I missing something?

If I read the documentation https://symfony.com/doc/master/bundles/FOSRestBundle/2-the-view-layer.html. Why would I need a rest-bundle to render a twig template? I can do that with symfony core very conveniently.

@xabbuh xabbuh force-pushed the xabbuh:symfony5-compat branch 10 times, most recently from 1c1c1df to 18d78f3 Feb 7, 2020
@@ -72,9 +70,6 @@ public function onKernelView($event)
}

if ($configuration instanceof ViewAnnotation) {

This comment has been minimized.

Copy link
@Tobion

Tobion Feb 9, 2020

Member

$configuration = $request->attributes->get('_template'); where does the _template attribute get set? It seems the Sensio FrameworkExtraBundle can set this attribute. But how can it contain the FosRestBudnle view annotation?

This comment has been minimized.

Copy link
@xabbuh

xabbuh Feb 10, 2020

Author Member

IIRC that's happening because or @View annotation extends the @Template annotation from the SensioFrameworkExtraBundle.

This comment has been minimized.

Copy link
@Tobion

Tobion Feb 11, 2020

Member

I see. I think we should also remove this inheritance.

@xabbuh xabbuh force-pushed the xabbuh:symfony5-compat branch 2 times, most recently from bf5d53f to 5cbe68f Feb 11, 2020
@xabbuh xabbuh force-pushed the xabbuh:symfony5-compat branch from 5cbe68f to 856224b Feb 13, 2020
@xabbuh xabbuh marked this pull request as ready for review Feb 13, 2020
xabbuh added a commit that referenced this pull request Feb 13, 2020
This PR was merged into the 3.0-dev branch.

Discussion
----------

add Travis CI job using Symfony 5 components

Commits
-------

856224b add Travis CI job using Symfony 5 components
@xabbuh xabbuh merged commit 856224b into FriendsOfSymfony:master Feb 13, 2020
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xabbuh xabbuh deleted the xabbuh:symfony5-compat branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.