Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed used alias for "FOS\RestBundle\View\ViewHandlerInterface" #2085

Open
wants to merge 1 commit into
base: master
from

Conversation

@enricog84
Copy link

enricog84 commented Feb 7, 2020

Changed FOS\RestBundle\View\ViewHandlerInterface to be an alias of "fos_rest.view_handler" instead of "fos_rest.view_handler.default". So in case if a custom ViewHandler has been configured under "fos_rest.service.view_handler" it will be used. Before this change, the used ViewHandler of Controller extending the AbstractFOSRestController would always have been pointing to fos_rest.view_handler.default because the service subscriber definition is $subscribedServices['fos_rest.view_handler'] = ViewHandlerInterface::class;.

This should fix #2029

…g "fos_rest.view_handler" instead of "fos_rest.view_handler.default" so in case a custom ViewHandler has been configured under "fos_rest.service.view_handler" it will be used.
@Tobion
Tobion approved these changes Feb 7, 2020
Copy link
Member

Tobion left a comment

Probably a bug fix for 2.x

@xabbuh xabbuh added this to the 2.7 milestone Feb 8, 2020
@xabbuh
xabbuh approved these changes Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.