Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the templating integration #2088

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@xabbuh
Copy link
Member

xabbuh commented Feb 8, 2020

No description provided.

@xabbuh xabbuh added this to the 2.8 milestone Feb 8, 2020
@xabbuh xabbuh force-pushed the xabbuh:templating-deprecation branch 5 times, most recently from 0fa4420 to c4fd83d Feb 8, 2020
@xabbuh xabbuh force-pushed the xabbuh:templating-deprecation branch 13 times, most recently from 4925a88 to 3144984 Feb 9, 2020
@xabbuh xabbuh marked this pull request as ready for review Feb 10, 2020
@xabbuh xabbuh requested review from GuilhemN, lsmith77 and Tobion Feb 10, 2020
@lsmith77

This comment has been minimized.

Copy link
Member

lsmith77 commented Feb 10, 2020

I think there might still be a few features lurking around in the ViewHandler that are only useful for HTML rendering. I briefly looked over the code and one feature that I noticed was force_redirects. This was basically about if when creating a resource if one should return the URL to the resource or redirect to the resource. The later bit I would say doesn't really make sense for a pure REST API

@xabbuh xabbuh force-pushed the xabbuh:templating-deprecation branch 2 times, most recently from 3600eb6 to b6ec74b Feb 11, 2020
@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Feb 11, 2020

@lsmith77 Good point, I also deprecated setting the force_redirects option.

@xabbuh xabbuh force-pushed the xabbuh:templating-deprecation branch from b6ec74b to 47a760e Feb 11, 2020
@xabbuh xabbuh force-pushed the xabbuh:templating-deprecation branch from 47a760e to 6aff09d Feb 11, 2020
@Tobion
Tobion approved these changes Feb 11, 2020
Copy link
Member

Tobion left a comment

Well done

xabbuh added a commit that referenced this pull request Feb 11, 2020
This PR was merged into the 2.x branch.

Discussion
----------

deprecate the templating integration

Commits
-------

6aff09d deprecate the templating integration
@xabbuh xabbuh merged commit 6aff09d into FriendsOfSymfony:2.x Feb 11, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xabbuh xabbuh deleted the xabbuh:templating-deprecation branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.