Change route fallback action to PATCH instead of POST. Fixes #223 #224

Merged
merged 2 commits into from Apr 19, 2012

Conversation

Projects
None yet
5 participants
Owner

asm89 commented Apr 5, 2012

This PR introduces a BC break because routes will now default to the PATCH method instead of POST (#223).

The docs are updated to reflect this change. Is there another place where the BC break should be noted?

Owner

asm89 commented Apr 5, 2012

ping @everzet :)

Owner

stof commented Apr 5, 2012

@asm89 you should add a new section in the UPGRADING file

@lsmith77 as it is a BC break, it should probably not be merged in the 0.6 branch

Owner

everzet commented Apr 5, 2012

@asm89 agree with both points from @stof

Contributor

Dattaya commented Apr 5, 2012

About documentation, all these actions now by default accept PATCH method and instead of

Define resource actions
public function lockUserAction($slug)
{} // "lock_user" [POST] /users/{slug}/lock
public function banUserAction($slug)
{} // "ban_user" [POST] /users/{slug}/ban
public function voteUserCommentAction($slug, $id)
{} // "vote_user_comment" [POST] /users/{slug}/comments/{id}/vote

should be:

Define resource actions
public function lockUserAction($slug)
{} // "lock_user" [PATCH] /users/{slug}/lock
public function banUserAction($slug, $id)
{} // "ban_user" [PATCH] /users/{slug}/ban
public function voteUserCommentAction($slug)
{} // "vote_user_comment" [PATCH] /users/{slug}/comments/{id}/vote

Owner

lsmith77 commented Apr 10, 2012

@asm89 can you add a note to the UPGRADING guide?

@asm89 asm89 merged commit baff2cf into FriendsOfSymfony:master Apr 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment