Adding the "LINK" http method to the route generation #323

Merged
merged 5 commits into from Dec 9, 2012

Conversation

Projects
None yet
3 participants
@OwlyCode
Contributor

OwlyCode commented Nov 11, 2012

When using the feature described here:

https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/Resources/doc/5-automatic-route-generation_single-restful-controller.md

You may now declare linkAction(), or linkSomethingAction() in your controller when using an autogenerated route from FosRestBundle.

It works well alone but would be great if merged at the same time with #288 to offer a full LINK method support.

Adding the "link" method to the route generator.
You may now declare linkAction() in your controller when using an autogenerated route from FosRestBundle.
@mvrhov

This comment has been minimized.

Show comment Hide comment
@mvrhov

mvrhov Nov 11, 2012

Contributor

I thought that the link method was removed from http specs...

Contributor

mvrhov commented Nov 11, 2012

I thought that the link method was removed from http specs...

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Nov 11, 2012

Member

isn't there another PR related to link?

Member

lsmith77 commented Nov 11, 2012

isn't there another PR related to link?

@OwlyCode

This comment has been minimized.

Show comment Hide comment
@OwlyCode

OwlyCode Nov 11, 2012

Contributor

Yep there's one PR related, it's about adding an annotation for Link method. Concerning the removal of link from the http specs, I effectively can't see it in the http 1.1 specification.

I followed this guide for REST implementation wich is promoting the use of the LINK method.

http://williamdurand.fr/2012/08/02/rest-apis-with-symfony2-the-right-way/

Contributor

OwlyCode commented Nov 11, 2012

Yep there's one PR related, it's about adding an annotation for Link method. Concerning the removal of link from the http specs, I effectively can't see it in the http 1.1 specification.

I followed this guide for REST implementation wich is promoting the use of the LINK method.

http://williamdurand.fr/2012/08/02/rest-apis-with-symfony2-the-right-way/

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Nov 17, 2012

Member

i will be working on the topic of HATEOAS in the coming days with @beberlei. i will then decide if we want to support this or not ..

Member

lsmith77 commented Nov 17, 2012

i will be working on the topic of HATEOAS in the coming days with @beberlei. i will then decide if we want to support this or not ..

@lsmith77 lsmith77 referenced this pull request Nov 18, 2012

Closed

LINK support #325

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Dec 5, 2012

Member

if you can add some docs i will merge it .. even though LINK is not anymore part of the spec.

Member

lsmith77 commented Dec 5, 2012

if you can add some docs i will merge it .. even though LINK is not anymore part of the spec.

@OwlyCode

This comment has been minimized.

Show comment Hide comment
@OwlyCode

OwlyCode Dec 6, 2012

Contributor

Nice ! Since the change I made is really tiny (actually a one line change), where can I put the doc ?

Contributor

OwlyCode commented Dec 6, 2012

Nice ! Since the change I made is really tiny (actually a one line change), where can I put the doc ?

@lsmith77

This comment has been minimized.

Show comment Hide comment
@lsmith77

lsmith77 Dec 6, 2012

Member

same place as the docs you linked in the description.

Member

lsmith77 commented Dec 6, 2012

same place as the docs you linked in the description.

@OwlyCode

This comment has been minimized.

Show comment Hide comment
@OwlyCode

OwlyCode Dec 8, 2012

Contributor

I made the changes to the doc, adding the methods to the full example and some documentation at the bottom, where the list of the available http methods lives.

Also, I added the unlink method as it would be inconsistent not to provide it. However I'm aware it is an undiscussed feature. Tell me if you want me to remove it while a choice is made about it.

Contributor

OwlyCode commented Dec 8, 2012

I made the changes to the doc, adding the methods to the full example and some documentation at the bottom, where the list of the available http methods lives.

Also, I added the unlink method as it would be inconsistent not to provide it. However I'm aware it is an undiscussed feature. Tell me if you want me to remove it while a choice is made about it.

@lsmith77 lsmith77 closed this Dec 9, 2012

@lsmith77 lsmith77 reopened this Dec 9, 2012

lsmith77 added a commit that referenced this pull request Dec 9, 2012

Merge pull request #323 from tmaindron/master
Adding the "LINK" http method to the route generation

@lsmith77 lsmith77 merged commit a8a9bff into FriendsOfSymfony:master Dec 9, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment