Allow controller as services, even when the service ID is the controller class name #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he container before checking if it's a class name That allows to register controller as services in the container and use them in routes, even when we register them by their class name in the container.
lsmith77
added a commit
that referenced
this pull request
Apr 12, 2014
Allow controller as services, even when the service ID is the controller class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background behind this issue is here: #604 (comment)
The RestRouteLoader now first check if the resource is a service in the container before checking if it's a class name.
That allows to register controller as services in the container and use them in routes, even when we register them by their class name in the container.
The tests turned out to be a bit messy. I tried to keep it clean, but if you want me to remove it I can. I also confirm that the test was failing before the fix, and is now passing after the change in RestRouteLoader.