New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release alpha4 #2206

Closed
ghost opened this Issue Sep 2, 2016 · 36 comments

Comments

Projects
None yet
@ghost
Copy link

ghost commented Sep 2, 2016

Hey,

thanks for this awesome bundle. Would it possible, that you release alpha4? Alpha3 is from late 2015 and I dont want to use dev-master.

Best,
Christian

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Sep 6, 2016

I will work on that in the coming weeks.

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Sep 19, 2016

@XWB What's the situation for now? 😄

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Sep 28, 2016

@XWB, all other contributors, I don't know, @stof, @Ener-Getick, anyone, come on, I know I'm quite pushing you, but last alpha was released more than a year ago, and actual master branch is perfectly fine for 99% apps.

I see you are merging some pull requests, do you need help in creating the changelog for the alpha release? If you need help just ask contributors, everyone here wants a new release of the most famous Symfony bundle, especially since SF3 has been released for almost a year.

Community (me included if you like) will be really pleased to help you in releasing this new version, and don't mind bugs or anything, there are patch versions for this, and everyone will be happy.

No offense, I just think it's better to help everyone have a good composer dependency tree with no silly constraint like dev-master in it.

Just one single release for 2.0.0

@GuilhemN

This comment has been minimized.

Copy link
Member

GuilhemN commented Sep 28, 2016

@Pierstoval i completely agree with you,.
Unfortunately, i'm not a regular contributor to this bundle and i don't know what are the current projects/aims so i can't release a new stable version myself without taking the risks of breaking them (maybe we're waiting for a new feature or a bug fix i don't know).

If @stof agrees (he's the last in charge if i'm not wrong?) I can of course take a look at the pending PRs/issues and then release 2.0.

@rjd22

This comment has been minimized.

Copy link

rjd22 commented Sep 29, 2016

@Ener-Getick it would be okay if it was an alpha release I think. Doesn't have to be stable.

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Sep 29, 2016

@Ener-Getick Actually as said, at least an alpha release is fairly enough and does not imply generating a big changelog (because the changelog gets bigger and bigger in time).

Releasing 2.0.0 is a much harder task because we have to explain users what changed since 1.x, and as I said, the community will be happy to help writing a big exhaustive changelog for 2.x :)

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Sep 30, 2016

@Pierstoval I think we can tag a new alpha when the last 4 PR's have been merged, see https://github.com/FriendsOfSymfony/FOSUserBundle/pulls?q=is%3Aopen+is%3Apr+milestone%3A2.0

@crmpicco

This comment has been minimized.

Copy link

crmpicco commented Oct 14, 2016

👍 for a 2.0.0 release

@pdoreau

This comment has been minimized.

Copy link

pdoreau commented Oct 19, 2016

I'm moving from SF 2.8 to 3. Is the alpha3 version stable enough for an app in production ?

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Oct 19, 2016

@pdoreau alpha3 is not compatible enough with SF3, you'll have to either wait for alpha4 ( ping @XWB 😄 ) or use dev-master and implement integration tests to be sure everything works well

@pdoreau

This comment has been minimized.

Copy link

pdoreau commented Oct 19, 2016

Sure, a stable release would indeed be more than appreciated. I guess many developers don't wanna rely on an alpha dependency.

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Oct 19, 2016

@pdoreau you can help by reviewing all 2.0 milestone PRs and it'll make things advance much faster 😉

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Nov 8, 2016

We still have one outstanding PR #1956

Will try to work on it asap.

@tgalopin

This comment has been minimized.

Copy link
Member

tgalopin commented Nov 16, 2016

Now that it's merged, is a release possible?

@lbayerl

This comment has been minimized.

Copy link

lbayerl commented Nov 18, 2016

Is there anything we can support you to release 2.0.0? E.g. support in documentation, upgrade, examples, ...?

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Nov 22, 2016

Before we do so, I have three questions:

  • Does @stof has some breaking changes he wants to be merged in this release?
  • What to do with Propel, it may have been fixed in symfony/symfony@59f9949 but I cannot test it.
  • Are we happy with names of the newest events added in master?

Ideally we have all breaking changes in alpha 4 so we can works towards the first beta. If not, we may need another alpha release.

@stof

This comment has been minimized.

Copy link
Member

stof commented Nov 22, 2016

@XWB I have a remaining breaking change (making some DB fields nullable, and maybe removing some others but to be discussed). I will send PRs for them.

Regarding Propel, I'm all for removing it from FOSUserBundle itself, as it causes too much issues.

Regarding doc, it would be great to review it in details (but this is not a blocker for the release, as we can still patch it after if necessary). But helping with the doc is very welcome

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Nov 22, 2016

Regarding Propel, I'm all for removing it from FOSUserBundle itself, as it causes too much issues.

I'm totally 👍 👍 👍 👍 👍 for this 👏

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Nov 22, 2016

I just merged #2309 so Propel support is now gone in the latest master branch.

If @stof sends his remaining PR's, we can tag the next release.

@stof

This comment has been minimized.

Copy link
Member

stof commented Nov 28, 2016

@XWB remaining blocker for the release: figuring out why one of the jobs fail on Travis in the master branch (I don't want to release with a red build)

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Nov 28, 2016

@stof Well #2319 seems to fix it, though I'm not sure why. Apparently Travis installs Symfony 2.7.8 instead of the latest 2.7.x version.

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Nov 28, 2016

@stof Master branch is green again, we are good to go.

@XWB

This comment has been minimized.

Copy link
Member

XWB commented Nov 29, 2016

@XWB XWB closed this Nov 29, 2016

@lbayerl

This comment has been minimized.

Copy link

lbayerl commented Nov 29, 2016

Thank you so much!

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Nov 29, 2016

Awesome 👏 👍 🎉

@OskarStark

This comment has been minimized.

Copy link

OskarStark commented Nov 29, 2016

Great work @XWB 👏

@ghost

This comment has been minimized.

Copy link

ghost commented Dec 2, 2016

Thank you very much! 👍

@samayo

This comment has been minimized.

Copy link

samayo commented Jan 11, 2017

So, I have been reading these comments, and need to make sure. Is 2.0.0 compatible with Symfony 3.x? I have 3.2 and not sure what if I can use this bundle without problems.

@Tomsgu

This comment has been minimized.

Copy link

Tomsgu commented Jan 11, 2017

It is compatible with symfony 3.x. The only problem is that 2.0.0 is still in beta so you should be aware of it and probably will be in beta still some time (months?).

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Jan 11, 2017

@Tomsgu Years? 2.0.0 is "ready" to me, but as I'm not a contributor/maintainer I can't judge about what's been decided internally about 2.0 milestones (except for #2378 which is not yet finished)

@Tomsgu

This comment has been minimized.

Copy link

Tomsgu commented Jan 11, 2017

@Pierstoval No I am not judging here. I think it's important to know that it's still "unstable", so people should be careful when using it in production. Btw. I use it for months as well.

@Pierstoval

This comment has been minimized.

Copy link

Pierstoval commented Jan 11, 2017

Same for me, and my tests have never regressed even when I was using dev-master (actually they did, but for very little things, and was not breaking the app itself, and could fix this before deploying easily).

For my students I always recommend 2.0@beta version constraint to be sure they get the "almost-stable" version

@stof

This comment has been minimized.

Copy link
Member

stof commented Jan 11, 2017

@samayo please don't comment on old unrelated closed issues to ask for support. It does not make your question discoverable.
and the doc explains this param: http://symfony.com/doc/master/bundles/FOSUserBundle/index.html#step-5-configure-the-fosuserbundle

@Pierstoval

This comment has been minimized.

@samayo

This comment has been minimized.

Copy link

samayo commented Jan 11, 2017

@stof Initially I was not sure if 2.0.0 supported Sf3 that is why I asked. About the error, I read the same doc you linked and it didn't work and I had to ask

@stof

This comment has been minimized.

Copy link
Member

stof commented Jan 11, 2017

@samayo your previous comment talks about generating entity. the doc of the bundle never ask to use the entity generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment