fix variable name typo #2

merged 1 commit into from Mar 22, 2012


None yet
4 participants

mvrhov commented Mar 21, 2012

No description provided.


stof commented Mar 21, 2012

@schmittjoh does it make sense to merge changes in the old versions of the code when your refactoring ended to be a complete rewrite ? When do you expect to be able to complete the new version (at least being enough to become the master branch) ?

Well, as long as someone wants to maintain this branch, I guess making fixes does not hurt.

In my personal opinion however, I think a better time investment would be to add the remaining pieces to the rewritten version. As I don't need OAuth right now, I can't make any promises as to when I'll have time for it.

mvrhov commented Mar 21, 2012

Unfortunately I need it right now and before I started, I was told to make it work in one, max two days or we are going roll something on our own:(.

So It would be really nice if you could merge those fixes and the one implementing refresh token coming tomorrow.

arnaud-lb added a commit that referenced this pull request Mar 22, 2012

@arnaud-lb arnaud-lb merged commit b7684ff into FriendsOfSymfony:master Mar 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment