From 49ef8c2cee8119050bbd1aac0792b91202d66dec Mon Sep 17 00:00:00 2001 From: "Thomas A. Hirsch" Date: Sun, 11 Feb 2024 20:18:44 +0100 Subject: [PATCH 1/3] Mockery 1.6.7 > Using atMost()->times(1) to avoid deprecation warning. --- .../unit/Swift/CharacterStream/ArrayCharacterStreamTest.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/unit/Swift/CharacterStream/ArrayCharacterStreamTest.php b/tests/unit/Swift/CharacterStream/ArrayCharacterStreamTest.php index 3ed1c9488..b166245d7 100644 --- a/tests/unit/Swift/CharacterStream/ArrayCharacterStreamTest.php +++ b/tests/unit/Swift/CharacterStream/ArrayCharacterStreamTest.php @@ -252,7 +252,8 @@ public function testByteStreamCanBeImportingUsesValidator() $stream = new Swift_CharacterStream_ArrayCharacterStream($factory, 'utf-8'); $os->shouldReceive('setReadPointer') - ->between(0, 1) + ->atMost() + ->times(1) ->with(0); $os->shouldReceive('read')->once()->andReturn(pack('C*', 0xD0)); $os->shouldReceive('read')->once()->andReturn(pack('C*', 0x94)); @@ -284,7 +285,8 @@ public function testImportingStreamProducesCorrectCharArray() $stream = new Swift_CharacterStream_ArrayCharacterStream($factory, 'utf-8'); $os->shouldReceive('setReadPointer') - ->between(0, 1) + ->atMost() + ->times(1) ->with(0); $os->shouldReceive('read')->once()->andReturn(pack('C*', 0xD0)); $os->shouldReceive('read')->once()->andReturn(pack('C*', 0x94)); From 743b16ea6cef86b14c7fe532c41e1c7ddda9a880 Mon Sep 17 00:00:00 2001 From: "Thomas A. Hirsch" Date: Sun, 11 Feb 2024 20:20:30 +0100 Subject: [PATCH 2/3] PHP 8.2 > Creation of dynamic property Class::$property is deprecated --- tests/acceptance/Swift/Mime/AttachmentAcceptanceTest.php | 1 + tests/acceptance/Swift/Mime/EmbeddedFileAcceptanceTest.php | 1 + tests/acceptance/Swift/Mime/MimePartAcceptanceTest.php | 1 + 3 files changed, 3 insertions(+) diff --git a/tests/acceptance/Swift/Mime/AttachmentAcceptanceTest.php b/tests/acceptance/Swift/Mime/AttachmentAcceptanceTest.php index 920faed9b..11666b5be 100644 --- a/tests/acceptance/Swift/Mime/AttachmentAcceptanceTest.php +++ b/tests/acceptance/Swift/Mime/AttachmentAcceptanceTest.php @@ -8,6 +8,7 @@ class Swift_Mime_AttachmentAcceptanceTest extends \PHPUnit\Framework\TestCase private $cache; private $headers; private $emailValidator; + private $idGenerator; protected function setUp() { diff --git a/tests/acceptance/Swift/Mime/EmbeddedFileAcceptanceTest.php b/tests/acceptance/Swift/Mime/EmbeddedFileAcceptanceTest.php index 5603a67d7..3e614854d 100644 --- a/tests/acceptance/Swift/Mime/EmbeddedFileAcceptanceTest.php +++ b/tests/acceptance/Swift/Mime/EmbeddedFileAcceptanceTest.php @@ -8,6 +8,7 @@ class Swift_Mime_EmbeddedFileAcceptanceTest extends \PHPUnit\Framework\TestCase private $cache; private $headers; private $emailValidator; + private $idGenerator; protected function setUp() { diff --git a/tests/acceptance/Swift/Mime/MimePartAcceptanceTest.php b/tests/acceptance/Swift/Mime/MimePartAcceptanceTest.php index 5a12daad7..93780ee08 100644 --- a/tests/acceptance/Swift/Mime/MimePartAcceptanceTest.php +++ b/tests/acceptance/Swift/Mime/MimePartAcceptanceTest.php @@ -8,6 +8,7 @@ class Swift_Mime_MimePartAcceptanceTest extends \PHPUnit\Framework\TestCase private $cache; private $headers; private $emailValidator; + private $idGenerator; protected function setUp() { From 7207fe7c0e7da02a6d938103de89c3db52a4c275 Mon Sep 17 00:00:00 2001 From: "Thomas A. Hirsch" Date: Sun, 11 Feb 2024 20:22:29 +0100 Subject: [PATCH 3/3] Re-Enabling deprecation warnings as errors for tests. Closes #8 --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a60951dfe..9db70ac3b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -53,4 +53,3 @@ jobs: run: vendor/bin/simple-phpunit --verbose env: SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT: 1 - SYMFONY_DEPRECATIONS_HELPER: weak