Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more reproducible .zip files #182

Merged
merged 1 commit into from May 5, 2019

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Sep 2, 2018

While working on reproducible builds for openSUSE, I found that
the fs-uae.dat in our package varied for every build.

Therefore I propose this patch to
Create more reproducible .zip files
avoid indeterministic filesystem order
and use -X to omit extended attributes from zip file
to help make fs-uae package build reproducible

See https://reproducible-builds.org/ for why this is good.

One remaining issue is with mtimes that also get embedded into the zip.

touch -d@$CONSTANT can help there (but only with GNU touch).

or touch -r $REFERENCEFILE (works with GNU touch and BSD touch)

or we post-process it in our package build process with strip-nondeterminism -t zip

avoid indeterministic filesystem order
and use -X to omit extended attributes from zip file
to help make fs-uae package build reproducible

See https://reproducible-builds.org/ for why this is good.
@FrodeSolheim
Copy link
Owner

Looks good, thanks :)

@FrodeSolheim FrodeSolheim merged commit b7dc153 into FrodeSolheim:master May 5, 2019
@bmwiedemann bmwiedemann deleted the zip branch May 6, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants