Create more reproducible .zip files #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While working on reproducible builds for openSUSE, I found that
the fs-uae.dat in our package varied for every build.
Therefore I propose this patch to
Create more reproducible .zip files
avoid indeterministic filesystem order
and use -X to omit extended attributes from zip file
to help make fs-uae package build reproducible
See https://reproducible-builds.org/ for why this is good.
One remaining issue is with mtimes that also get embedded into the zip.
touch -d@$CONSTANTcan help there (but only with GNU touch).or
touch -r $REFERENCEFILE(works with GNU touch and BSD touch)or we post-process it in our package build process with
strip-nondeterminism -t zip